Fix JavaScript error with min/max value set in DateTime #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once a date field (year, month or day) is changed with min/max limit set, DateTime.js#_applyLimitRestriction is called to ensure that the new date is not outside the range. If you set all three fields together, using _setDate, the intermidiate validation (after every field) can lead to endless recursion. Avoid calling DateTime.js#_applyLimitRestriction before all the three fields are set. Fix: #253
mknauer
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One a date filed (year, month or day) is changed with min/max limit set, DateTime.js#_applyLimitRestriction is called to ensure that the new date in not outside the range. If you set all three fields together, using _setDate, the intermidiate validation (after every filed) can lead to endless recursion.
Avoid calling DateTime.js#_applyLimitRestriction before all the three fields are set.
Fix: #253